ncdu: 1.16 -> 2.0 #152163
ncdu: 1.16 -> 2.0 #152163
Conversation
|
I think this is because upstream requires Zig 0.9.0 specifically, and we have 0.8.1 in nixpkgs. |
|
Unfortunately, that's also broken: https://code.blicky.net/yorhel/ncdu/issues/183 |
|
Unfortunately, due to #86299 preventing zig from working, this update would prevent mac users from using ncdu which is a major regression for me and many others who often use this tool. We would have to keep the old ncdu around and make it default for mac users if we don't want to regress. This might be a good idea anyways since the ncdu 2.0 introduces new features like color some users might not want. @toonn do you know whether the system libraries issue will be resolved any time soon? |
Oh ... that's no good |
pkgs/tools/misc/ncdu/default.nix
Outdated
| ./c-import-order.patch # https://code.blicky.net/yorhel/ncdu/issues/183 | ||
| ]; | ||
|
|
||
| XDG_CACHE_HOME="Cache"; # FIXME This should be set in stdenv |
There was a problem hiding this comment.
If XDG_CACHE_HOME is unset it should fallback to $HOME/.cache. So creating $HOME should be enough.
There was a problem hiding this comment.
Is there an idiomatic way of doing that?
There was a problem hiding this comment.
That should be done at the program level otherwise the implementation is wrong.
There was a problem hiding this comment.
We set $HOME to homeless-shelter in Nixpkgs though, don't we?
This issue looks like it has been fixed in zig 0.9.0. Let me confirm this... Edit: oops, never mind, I thought that was a zig issue for a moment 😅 Edit2: OK but I am curious why this issue would prevent Zig from working. Zig minimally depends on the system that it runs on, and thus tends to work regardless of weird system configurations. What's the issue specifically? |
|
Next to the broken declaration in Zig's meta is a link to the issue I mentioned, so it's probably due to dependence on some macOS system library. You'd know better than me exactly what parts of a system zig depends on though ;) |
|
Would it be an idea to publish this as ncdu_2, rename the current one to ncdu_1 and then add an alias that uses v1 on mac and v2 on linux? |
|
Agree with the side-by-side packaging. 2.0 won't fully replace 1.x for some time so we should keep it for a bit. According to upstream,
I think the system-dependent alias is too much magic though. Best to keep |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Motivation for this change
Currently broken upstream it seems: https://code.blicky.net/yorhel/ncdu/issues/184
Edit: Depends on #152163 but still broken: https://code.blicky.net/yorhel/ncdu/issues/183
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes